NickAkhmetov/Add support for obs_labels_names and obs_labels_paths arrays
#272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickAkhmetov
changed the title
obs_labels_names and obs_labels_paths arraysobs_labels_names and obs_labels_paths arrays
keller-mark
approved these changes
Aug 11, 2023
Co-authored-by: Mark Keller <7525285+keller-mark@users.noreply.github.com>
|
Great catches on those improvements, that's a much safer approach 👍 |
NickAkhmetov
deleted the
nickakhmetov/add-support-for-multiple-obs-labels
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support and tests for the
obs_labels_namesandobs_labels_pathsprops for the AnndataWrapper to allow passing more than one set of obs labels and corresponding display names. I kept the legacyobs_labels_pathprop in place but indicated it is deprecated.